Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add state for import #3485

Merged
merged 4 commits into from
Nov 8, 2024
Merged

add state for import #3485

merged 4 commits into from
Nov 8, 2024

Conversation

SabrinaTardio
Copy link
Collaborator

@SabrinaTardio SabrinaTardio commented Oct 31, 2024

Task/Issue URL: https://app.asana.com/0/1204186595873227/1208592742896624/f

Description: Adds a state for the import action

Steps to test this PR:

  1. In main window controller comment out line 73-82 and 85
  2. run ./clean-app.sh debug
  3. in the startOnboarding function in Tab do setContent(.onboarding) and return
  4. Tun the app go through the onboarding until it asks you to import
  5. Press import, check the dialog opens
  6. cancel and check the FE UI shows the import button
  7. try again and import something
  8. once the dialog is closed check the FE UI shows a green tick

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@alessandroboron alessandroboron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

SabrinaTardio added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Nov 8, 2024
Task/Issue URL:
https://app.asana.com/0/1204186595873227/1208592742896624/f
iOS PR: 
macOS PR:  duckduckgo/macos-browser#3485
What kind of version bump will this require?: Minor

**Description**:  Updated C-S-S dependency
@SabrinaTardio SabrinaTardio merged commit 397af5e into main Nov 8, 2024
18 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/onboarding-import-state branch November 8, 2024 18:18
samsymons added a commit that referenced this pull request Nov 12, 2024
# By Dax the Duck (5) and others
# Via GitHub (3) and Juan Manuel Pereira (1)
* main:
  Remediate TunnelVision, TunnelCrack and fix "Exclude Local Networks" (#3422)
  Sync: Send pixels for account removal + decoding issues (#3530)
  Send success pixel on successful data import (#3437)
  Bump version to 1.114.0 (304)
  Set marketing version to 1.114.0
  Update embedded files
  Introduce report broken site prompt on triple refresh page (#3523)
  add state for import (#3485)
  Bump version to 1.113.0 (303)
  Do not use suggestion view controller visibility to set suggestion (#3529)
  Fix SwiftLint
  Fix SwiftLint
  Update phishing protection datasets to 1686837 (#3494)
  Bump version to 1.113.0 (302)
  Update permission string for location popup (#3526)
  Send auth state with sync unexpectedly disabled pixel (#3521)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
mgurgel pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Nov 18, 2024
Task/Issue URL:
https://app.asana.com/0/1204186595873227/1208592742896624/f
iOS PR:
macOS PR:  duckduckgo/macos-browser#3485
What kind of version bump will this require?: Minor

**Description**:  Updated C-S-S dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants